22440: _list_files loaded zsh/stat too early

unposted: document the use of stat builtin
unposted: improve docs for $$ and $PPID

4 files changed, 22 insertions, 5 deletions

diff --git a/ChangeLog b/ChangeLog
index 6d3c0df53..1841df4ca 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2006-05-12  Peter Stephenson  <pws@csr.com>
+
+	* unposted: Doc/Zsh/params.yo: improve documentation for $$
+	and $PPID.
+
+	* unposted: Doc/Zsh/compsys.yo: document that _list_files
+	uses the builtin state, c.f. 22440.
+
+	* 22440: Completion/Unix/Type/_list_files: loaded zsh/stat
+	if not needed, which screwed up external stat programmes.
+
 2006-05-05  Wayne Davison  <wayned@users.sourceforge.net>
 
 	* unposted: Completion/Unix/Command/_bzr: fixed the completion
diff --git a/Completion/Unix/Type/_list_files b/Completion/Unix/Type/_list_files
index 2166ac6cc..bd5c1fa62 100644
--- a/Completion/Unix/Type/_list_files
+++ b/Completion/Unix/Type/_list_files
@@ -15,8 +15,6 @@ integer ok
 listfiles=()
 listopts=()
 
-zmodload -i zsh/stat 2>/dev/null || return 1
-
 zstyle -a ":completion:${curcontext}:" file-list stylevals || return 1
 
 # TODO: more flexible way of handling the following?  e.g. use $compstate?
@@ -48,6 +46,8 @@ done
 
 (( ok )) || return 1
 
+zmodload -i zsh/stat 2>/dev/null || return 1
+
 for f in ${(P)1}; do
   if [[ ! -e "${2:+$2/}$f" ]]; then
     listfiles+=("${2:+$2/}$f")
diff --git a/Doc/Zsh/compsys.yo b/Doc/Zsh/compsys.yo
index f0bbc56c3..facd589a5 100644
--- a/Doc/Zsh/compsys.yo
+++ b/Doc/Zsh/compsys.yo
@@ -1268,7 +1268,8 @@ item(tt(file-list))(
 This style controls whether files completed using the standard builtin
 mechanism are to be listed with a long list similar to tt(ls -l)
 (although note that this feature actually uses the shell module
-tt(zsh/stat) for file information).
+tt(zsh/stat) for file information; this lods the builtin tt(stat)
+which will replace any external tt(stat) executable).
 
 The style may either be set to a true value (or `tt(all)'), or
 one of the values `tt(insert)' or `tt(list)', indicating that files
diff --git a/Doc/Zsh/params.yo b/Doc/Zsh/params.yo
index a91e99fbd..9212f8593 100644
--- a/Doc/Zsh/params.yo
+++ b/Doc/Zsh/params.yo
@@ -473,7 +473,10 @@ Same as tt(#).
 )
 vindex($)
 item(tt($) <S>)(
-The process ID of this shell.
+The process ID of this shell.  Note that this indicates the original
+shell started by invoking tt(zsh); all processes forked from the shells
+without executing a new program, such as subshells started by
+tt(LPAR())var(...)tt(RPAR()), substitute the same value.
 )
 vindex(-)
 item(tt(-) <S>)(
@@ -609,7 +612,9 @@ The operating system, as determined at compile time.
 )
 vindex(PPID)
 item(tt(PPID) <S>)(
-The process ID of the parent of the shell.
+The process ID of the parent of the shell.  As for tt($$), the
+value indicates the parent of the original shell and does not
+change in subshells.
 )
 vindex(PWD)
 item(tt(PWD))(