summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOliver Kiddle <okiddle@yahoo.co.uk>2018-04-07 12:48:31 +0200
committerOliver Kiddle <okiddle@yahoo.co.uk>2018-04-07 14:37:46 +0200
commitbd05c4b2def7defee3787df24e2cfb9f96900e6c (patch)
treea1bce53bfdbc9ccd2b97ad4d6edac97f9e8e5c2b
parent583419839f475990a02eacfb03ebb6ae6b2c48b9 (diff)
downloadzsh-bd05c4b2def7defee3787df24e2cfb9f96900e6c.tar.gz
zsh-bd05c4b2def7defee3787df24e2cfb9f96900e6c.zip
42595: remove dead code flagged by coverity
-rw-r--r--ChangeLog2
-rw-r--r--Src/utils.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index b7ff4cbcc..2e20a7540 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
2018-04-07 Oliver Kiddle <okiddle@yahoo.co.uk>
+ * 42595: Src/utils.c: remove dead code flagged by coverity
+
* Matthew Martin: 42604: Completion/BSD/Command/_signify,
Completion/BSD/Command/_vmctl: new completions for OpenBSD's
signify and vmctl
diff --git a/Src/utils.c b/Src/utils.c
index 3587c3622..c544b81bf 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2486,9 +2486,7 @@ zstrtoul_underscore(const char *s, zulong *retval)
base = 2, s++;
else
base = isset(OCTALZEROES) ? 8 : 10;
- if (base < 2 || base > 36) {
- return 0;
- } else if (base <= 10) {
+ if (base <= 10) {
for (; (*s >= '0' && *s < ('0' + base)) ||
*s == '_'; s++) {
if (*s == '_')