summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog3
-rw-r--r--Test/B11kill.ztst9
2 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 9a7ca36a0..5fabad45c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
2020-02-18 Chris Down <chris@chrisdown.name>
+ * 45463: Test/B11kill.ztst: test: kill: Document why we use
+ SIGURG
+
* 45453: Src/jobs.c, Test/B11kill.ztst: builtins: kill: Do not
signal current process group when pid is empty
diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst
index 40dd99cd3..dc6bf9b89 100644
--- a/Test/B11kill.ztst
+++ b/Test/B11kill.ztst
@@ -60,6 +60,15 @@
?(eval):kill:2: not enough arguments
# Regression tests: `kill ''` should not result in `kill 0`.
+#
+# We use SIGURG where an explicit sigspec can be provided as:
+#
+# 1. By default it's non-terminal, so even if we regress, we won't kill the
+# test runner and other processes in the process group since we'll stop
+# running this test before we get to the plain kill (and thus SIGTERM)
+# cases;
+# 2. It's also unlikely to be sent for any other reason during the process
+# lifetime, so the test shouldn't be flaky.
(
trap 'exit 11' URG