summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog5
-rw-r--r--Src/glob.c4
-rw-r--r--Src/pattern.c8
3 files changed, 16 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 1456675bc..37043e679 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-08-09 Barton E. Schaefer <schaefer@zsh.org>
+
+ * 36033: Src/glob.c, Src/pattern.c: a few more queue_signals()
+ to protect global state changes
+
2015-08-09 Mikael Magnusson <mikachu@gmail.com>
* unposted: Test/C03traps.ztst: add tests for outputting traps
diff --git a/Src/glob.c b/Src/glob.c
index eff34a24e..f82c3bd30 100644
--- a/Src/glob.c
+++ b/Src/glob.c
@@ -216,22 +216,26 @@ static struct globdata curglobdata;
#define save_globstate(N) \
do { \
+ queue_signals(); \
memcpy(&(N), &curglobdata, sizeof(struct globdata)); \
(N).gd_pathpos = pathpos; \
(N).gd_pathbuf = pathbuf; \
(N).gd_glob_pre = glob_pre; \
(N).gd_glob_suf = glob_suf; \
pathbuf = NULL; \
+ unqueue_signals(); \
} while (0)
#define restore_globstate(N) \
do { \
+ queue_signals(); \
zfree(pathbuf, pathbufsz); \
memcpy(&curglobdata, &(N), sizeof(struct globdata)); \
pathpos = (N).gd_pathpos; \
pathbuf = (N).gd_pathbuf; \
glob_pre = (N).gd_glob_pre; \
glob_suf = (N).gd_glob_suf; \
+ unqueue_signals(); \
} while (0)
/* pathname component in filename patterns */
diff --git a/Src/pattern.c b/Src/pattern.c
index 8fa1a727f..7d38988a0 100644
--- a/Src/pattern.c
+++ b/Src/pattern.c
@@ -520,6 +520,8 @@ patcompile(char *exp, int inflags, char **endexp)
char *lng, *strp = NULL;
Patprog p;
+ queue_signals();
+
startoff = sizeof(struct patprog);
/* Ensure alignment of start of program string */
startoff = (startoff + sizeof(union upat) - 1) & ~(sizeof(union upat) - 1);
@@ -582,8 +584,10 @@ patcompile(char *exp, int inflags, char **endexp)
if (!strp || (*strp && *strp != '/')) {
/* No, do normal compilation. */
strp = NULL;
- if (patcompswitch(0, &flags) == 0)
+ if (patcompswitch(0, &flags) == 0) {
+ unqueue_signals();
return NULL;
+ }
} else {
/*
* Yes, copy the string, and skip compilation altogether.
@@ -715,6 +719,8 @@ patcompile(char *exp, int inflags, char **endexp)
if (endexp)
*endexp = patparse;
+
+ unqueue_signals();
return p;
}