| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
_vcs_info_hooks as a top-level helper function.
|
|
See discussion in workers/45460.
|
|
The following case was encountered in the wild:
% zsh; echo "$?"
% trap 'exit 5' TERM
% kill ''
5
This behaviour seems more likely to be the result of bugs in programs
(e.g. `kill -9 "$unsetvar") rather than being desirable
behaviour to me. It also seems unintentional judging by the code and
documentation, since it comes about as a result of the fact that:
- `isanum` returns true for empty strings (since an empty string
technically only consists of digits and minuses...);
- `atoi`, when passed a pointer to an invalid number, returns 0;
- `kill(0, signal)` sends the signal in question to all processes in the
current process group.
There are (at least) two ways to solve this issue:
1. Add special handling to `kill` to avoid this case. See this patch[0]
for a version that does that.
2. Change how isanum behaves. Since the only two call sites that use it
both seem like they should handle the case where the input char array
is empty, that seems like a reasonable overall change to me.[1]
After this patch:
% trap 'exit 5' TERM
% kill ''
kill: illegal pid:
The regression test for `kill` without a sigspec is also included in
this commit, as previously it's not possible to test it trivially as it
would still kill the test runner in expected-to-fail mode; see
discussion in workers/45449.
0: workers/45426: https://www.zsh.org/mla/workers/2020/msg00251.html
1: The other call site using isanum() is the fg builtin, but in that
case we just fail later since we can't find any job named '', so no
big deal either way. It's the kill case which is more concerning.
|
|
The version without a sigspec can't be added yet because it would still
kill the test runner even in expected-to-fail mode; see workers/45449
for discussion. For the same reason, we use a signal which is non-fatal
by default and unlikely to be sent by someone else, SIGURG, to do the
expected-to-fail case prior to the fix.
|
|
This is not totally comprehensive, but at least it's a start for the
core functionality. In the next commits, we'll also use this base to add
some regression tests.
|
|
We currently detect Git repositories by finding the top level of the
working tree, and if we fail to detect it, assume that we're not in a
repository. However, there's a case we don't consider: a bare
repository.
Let's detect if the user is in a bare repository by checking if gitdir
is set, and if so, using that if there is no working tree. We now
detect bare Git repositories with vcs_info, as expected.
|
|
Git 2.25 introduced a change to how git rev-parse --show-toplevel
behaves. Traditionally, it succeeded with no output if the user was
in a bare repository. Now it dies, printing an error to standard error.
Consequently, when the user is in a bare repository with a newer Git,
vcs_info prints noisily to standard error.
While this is functionally harmless, it is annoying for the shell to
print messages from Git every time the prompt is printed, so let's
silence the error message.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* Pass RGID instead of passwd GID to initgroups()
* Clean up #ifdefs, avoid unnecessary checks
* Flatten conditions
|
|
- Fix retval handling in bin_setopt()
- Don't skip_setuid / skip_setgid. It's not our place to optimize away noops
(that might not even _be_ noops; they might change the saved uid…).
- Remove HAVE_* guard checks around functions that are used unguarded elsewhere.
- Use bsd-setres_id.c from OpenSSH to provide setresuid() / setresgid()
everywhere, and thus simplify the ifdef soup. Fix some preëxisting
bugs in the macro definitions of setuid() (do we still need that one?).
- Fix zwarning() format codes for variadic arguments type safety
- Restored a comment from HEAD
- Fix failure modes around initgroups()
- Compared privilege restoration code with OpenSSH's permanently_drop_uid() and
updated as needed
- Add E01 PRIVILEGED sanity checks
|
|
|
|
|
|
Differences from ML post:
* Properly fix escaping issue with $usr (needs unescaped first)
* Make $shell emptiness check easier to read (per feedback)
|
|
|
|
("blacklisting"?) features.
|
|
|
|
|
|
|
|
|
|
and /home/daniel/in/zsh.
|
|
The flags need resetting for this branch otherwise e.g. command
substitution with non-zero status doesn't cause exit.
|
|
|
|
empty message
|
|
The queueing added in execarith() in 45083 is reverted since the callee
does this now.
|
|
|
|
|
|
change.
|
|
|
|
Signed-off-by: Eitan Adler <lists@eitanadler.com>
|
|
|
|
try/always.
|
|
Use 'pattern' to refer to things matched against contexts and 'metapattern'
to refer to things matched against patterns.
|
|
others: with an item()().
|
|
|
|
|
|
Otherwise, a signal handler might create files while the temporary umask
is in effect.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Technically all timezone formats support the "-local" suffix but it is
not meaningful for all of them. As such just list out the specific
formats which it does.
Also adjust the 'default' description
|
|
Add example of how to add a new binding for a widget that fixes
a particular word behaviour using styles.
|
