From 51409732d0e647661915fde0b15323005be7c9e8 Mon Sep 17 00:00:00 2001 From: Peter Stephenson Date: Tue, 22 Sep 2009 09:17:05 +0000 Subject: 27284: better use of movefd() --- Src/Modules/socket.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'Src/Modules/socket.c') diff --git a/Src/Modules/socket.c b/Src/Modules/socket.c index 469568a11..3f47636bc 100644 --- a/Src/Modules/socket.c +++ b/Src/Modules/socket.c @@ -120,13 +120,19 @@ bin_zsocket(char *nam, char **args, Options ops, UNUSED(int func)) } if (targetfd) { - redup(sfd, targetfd); - sfd = targetfd; + if (redup(sfd, targetfd) == -1) + sfd = -1; + else + sfd = targetfd; } else { /* move the fd since no one will want to read from it */ sfd = movefd(sfd); } + if (sfd == -1) { + zerrnam(nam, "cannot duplicate fd %d: %e", sfd, errno); + return 1; + } setiparam("REPLY", sfd); -- cgit v1.2.3