1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
|
#include <assert.h>
#include <errno.h>
#include <grp.h>
#include <pwd.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/types.h>
#include <unistd.h>
#include <utility>
#include <vector>
#ifdef NOISY
# define DEBUG(...) fprintf( stderr, __VA_ARGS__ )
#else
# define DEBUG(...) do { } while ( 0 )
#endif
uid_t parse_user( const char *user ) {
char *end;
unsigned long tmp;
DEBUG( "insecuresuexec parse_user( %s )\n", user );
tmp = strtoul( user, &end, 10 );
if ( end != user && ! *end ) {
DEBUG( " which is the uid %lu\n", tmp );
return tmp;
} else {
DEBUG( " which is a username\n" );
errno = 0;
struct passwd *pw = getpwnam( user );
assert_perror( errno );
assert( pw );
DEBUG( " corresponding to the uid %u\n", pw->pw_uid );
return pw->pw_uid;
};
}
gid_t parse_group( const char *group ) {
char *end;
unsigned long tmp;
DEBUG( "insecuresuexec parse_group( %s )\n", group );
tmp = strtoul( group, &end, 10 );
if ( end != group && ! *end ) {
DEBUG( " which is the gid %lu\n", tmp );
return tmp;
} else {
DEBUG( " which is a groupname\n" );
errno = 0;
struct group *gr = getgrnam( group );
assert_perror( errno );
assert( gr );
DEBUG( " corresponding to the gid %u\n", gr->gr_gid );
return gr->gr_gid;
};
}
class permission {
uid_t min_uid, max_uid;
gid_t min_gid, max_gid;
public:
permission( std::pair< uid_t, uid_t > uids, std::pair< gid_t, gid_t > gids )
: min_uid( uids.first )
, max_uid( uids.second )
, min_gid( gids.first )
, max_gid( gids.second )
{
}
const bool allows( uid_t uid, gid_t gid ) {
return uid >= min_uid && uid <= max_uid && gid >= min_gid && gid <= max_gid;
}
};
template< typename thing > std::pair< thing, thing > parse_pair( const char *line, thing (*parse_one)( const char *part ) ) {
std::pair< thing, thing > ret( 0, -1 );
size_t part_len = strlen( line );
assert( part_len > 0 );
char part[part_len + 1];
strncpy( part, line, part_len );
part[part_len] = 0;
size_t comma = strcspn( line, "," );
if ( comma == part_len ) {
thing it = parse_one( part );
ret.first = it;
ret.second = it;
} else {
size_t first_len = comma;
size_t second_len = part_len - comma - 1;
char first[first_len + 1];
strncpy( first, part, first_len );
first[first_len] = 0;
char second[second_len + 1];
strncpy( second, part + comma + 1, second_len );
second[second_len] = 0;
if ( first_len )
ret.first = parse_one( first );
if ( second_len )
ret.second = parse_one( second );
};
return ret;
}
permission parse_line( const char *line ) {
size_t line_len = strcspn( line, "\n" );
assert( line_len > 0 );
size_t user_len = strcspn( line, ":" );
assert( user_len != line_len );
size_t group_len = line_len - user_len - 1;
char user[user_len + 1];
strncpy( user, line, user_len );
user[user_len] = 0;
char group[group_len + 1];
strncpy( group, line + user_len + 1, group_len );
group[group_len] = 0;
auto uid_part = parse_pair< uid_t >( user, parse_user );
auto gid_part = parse_pair< gid_t >( group, parse_group );
return permission( uid_part, gid_part );
}
std::vector< permission > * read_permissions( const char *file ) {
FILE *fh = fopen( file, "r" );
if ( not fh )
assert_perror( errno );
auto *ret = new std::vector< permission >( );
char *line = 0;
size_t size = 0;
for ( ; getline( &line, &size, fh ) != -1; ) {
size_t line_len = strcspn( line, "\n" );
if ( line_len ) {
ret->push_back( parse_line( line ) );
};
};
if ( line )
free( line );
return ret;
}
int main( int argc, char *argv[] ) {
if ( argc < 4 ) {
fprintf( stderr, "Usage: %s user group cmd [args..]\n", argv[0] );
return 1;
};
char *user = argv[1];
char *group = argv[2];
char *cmd = argv[3];
char **args = argv + 3;
DEBUG( "insecuresuexec user=%s group=%s cmd=%s\n", user, group, cmd );
uid_t uid;
gid_t gid;
DEBUG( "insecuresuexec is parsing the command-line user and group...\n" );
uid = parse_user( user );
gid = parse_group( group );
// literally the only hard-coded security check
if ( not uid || not gid ) {
fprintf( stderr, "Neither uid nor gid may be zero!\n" );
_exit( 1 );
};
DEBUG( "insecuresuexec is parsing the stored permissions...\n" );
auto allowed = read_permissions( "/etc/insecuresuexec/permissions" );
DEBUG( "insecuresuexec is running the configured security checks...\n" );
// the configurable security checks
bool ok = false;
for ( auto i = allowed->begin( ); i != allowed->end( ); ++i ) {
ok |= i->allows( uid, gid );
if ( ok ) break;
};
if ( not ok ) {
fprintf( stderr, "The uid/gid pair %u/%u is not allowed!\n", uid, gid );
_exit( 1 );
};
DEBUG( "insecuresuexec is going to go ahead with the exec...\n" );
if ( setgroups( 0, NULL ) != 0 )
assert_perror( errno );
if ( setregid( gid, gid ) != 0 )
assert_perror( errno );
if ( setreuid( uid, uid ) != 0 )
assert_perror( errno );
execv( cmd, args );
assert_perror( errno );
}
|
