pinyweb: making '0' an acceptable variable value

7 files changed, 8 insertions, 8 deletions

diff --git a/pinyweb/cgi-bin/auth/addaccess.cgi b/pinyweb/cgi-bin/auth/addaccess.cgi
index fca9574..f86c19e 100755
--- a/pinyweb/cgi-bin/auth/addaccess.cgi
+++ b/pinyweb/cgi-bin/auth/addaccess.cgi
@@ -13,7 +13,7 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') && $q->param('n') ) {
+if( defined( $q->param('r') ) && defined( $q->param('n') ) ) {
   unless( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'addaccess', $q->param('r'), $q->param('n') ) == 0 ) {
     die( 'Addaccess was unsuccessful.' );
   };
diff --git a/pinyweb/cgi-bin/auth/lsaccess.cgi b/pinyweb/cgi-bin/auth/lsaccess.cgi
index f7c9a06..354ba32 100755
--- a/pinyweb/cgi-bin/auth/lsaccess.cgi
+++ b/pinyweb/cgi-bin/auth/lsaccess.cgi
@@ -13,7 +13,7 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') ) {
+if( defined( $q->param('r') ) ) {
   unless ( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'lsaccess', $q->param('r') ) == 0 ) {
     die( 'lsaccess was unsuccessful.' );
   };
diff --git a/pinyweb/cgi-bin/auth/newrepo.cgi b/pinyweb/cgi-bin/auth/newrepo.cgi
index 000be02..aa42732 100755
--- a/pinyweb/cgi-bin/auth/newrepo.cgi
+++ b/pinyweb/cgi-bin/auth/newrepo.cgi
@@ -13,7 +13,7 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') && $q->param('d') ) {
+if( defined( $q->param('r') ) && defined( $q->param('d') ) ) {
   unless( open2( OUT, IN, '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'newrepo', '--batch', $q->param('r') ) ) {
     die 'could not execute newrepo';
   };
diff --git a/pinyweb/cgi-bin/auth/pinyconfig.cgi b/pinyweb/cgi-bin/auth/pinyconfig.cgi
index af7cebd..4fd8e89 100755
--- a/pinyweb/cgi-bin/auth/pinyconfig.cgi
+++ b/pinyweb/cgi-bin/auth/pinyconfig.cgi
@@ -13,11 +13,11 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') && $q->param('n') && $q->param('v') ) {
+if( defined( $q->param('r') ) && defined( $q->param('n') ) && defined( $q->param('v') ) ) {
   unless( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'pinyconfig', $q->param('r'), $q->param('n'), $q->param('v') ) == 0 ) {
     die( 'pinyconfig was unsuccessful.' );
   };
-} elsif( $q->param('r') ) {
+} elsif( defined( $q->param('r') ) ) {
   unless( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'pinyconfig', $q->param('r') ) == 0 ) {
     die( 'pinyconfig was unsuccessful.' );
   };
diff --git a/pinyweb/cgi-bin/auth/rebuildrepo.cgi b/pinyweb/cgi-bin/auth/rebuildrepo.cgi
index 0d23fbd..912e004 100755
--- a/pinyweb/cgi-bin/auth/rebuildrepo.cgi
+++ b/pinyweb/cgi-bin/auth/rebuildrepo.cgi
@@ -13,7 +13,7 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') ) {
+if( defined( $q->param('r') ) ) {
   unless ( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'rebuildrepo', $q->param('r') ) == 0 ) {
     die( 'rebuildrepo was unsuccessful.' );
   };
diff --git a/pinyweb/cgi-bin/auth/rmaccess.cgi b/pinyweb/cgi-bin/auth/rmaccess.cgi
index 5123041..35736ab 100755
--- a/pinyweb/cgi-bin/auth/rmaccess.cgi
+++ b/pinyweb/cgi-bin/auth/rmaccess.cgi
@@ -13,7 +13,7 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') && $q->param('n') ) {
+if( defined( $q->param('r') ) && defined( $q->param('n') ) ) {
   unless ( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'rmaccess', $q->param('r'), $q->param('n') ) == 0 ) {
     die( 'rmaccess was unsuccessful.' );
   };
diff --git a/pinyweb/cgi-bin/auth/rmrepo.cgi b/pinyweb/cgi-bin/auth/rmrepo.cgi
index 2d0ff23..f57170a 100755
--- a/pinyweb/cgi-bin/auth/rmrepo.cgi
+++ b/pinyweb/cgi-bin/auth/rmrepo.cgi
@@ -13,7 +13,7 @@ $q = CGI->new;
 
 print( "Content-type: text/plain\n\n");
 
-if( $q->param('r') ) {
+if( defined( $q->param('r') ) ) {
   unless ( system( '/usr/sbin/piny-suid', $ENV{'REMOTE_USER'}, 'rmrepo', $q->param('r') ) == 0 ) {
     die( 'rmrepo was unsuccessful.' );
   };