diff options
| author | root <root@piny.svcs.cs.pdx.edu> | 2009-09-06 04:49:40 -0700 |
|---|---|---|
| committer | root <root@piny.svcs.cs.pdx.edu> | 2009-09-06 04:49:40 -0700 |
| commit | 814e7256e88a1e49e1a9f6d87b809f51f92317a5 (patch) | |
| tree | dd5587ac3246c11b80a7f9da8c440d6b7c6192c1 /usr/local/sbin/newrepo | |
| parent | 1cbe6712d6ed474885480b07437b19d55eb95398 (diff) | |
| download | piny-code-814e7256e88a1e49e1a9f6d87b809f51f92317a5.tar.gz piny-code-814e7256e88a1e49e1a9f6d87b809f51f92317a5.zip | |
Reordering operations to make wikilist and cgitrc races marginally less racy.
Diffstat (limited to 'usr/local/sbin/newrepo')
| -rwxr-xr-x | usr/local/sbin/newrepo | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr/local/sbin/newrepo b/usr/local/sbin/newrepo index 7988117..1545f48 100755 --- a/usr/local/sbin/newrepo +++ b/usr/local/sbin/newrepo @@ -203,8 +203,8 @@ print( WIKILIST "ikiwiki-$reponame /etc/ikiwiki/piny/$reponame.setup\n" ); # In close( WIKILIST ); $wikilisttempfile = `/bin/mktemp`; chomp( $wikilisttempfile ); -system( "/bin/cat /etc/ikiwiki/wikilist.d/* > $wikilisttempfile" ); chmod ( 0644, $wikilisttempfile ); +system( "/bin/cat /etc/ikiwiki/wikilist.d/* > $wikilisttempfile" ); system( "/bin/mv $wikilisttempfile /etc/ikiwiki/wikilist" ); # This is marginally racy, but the consequences are probably ignorable. open ( CGITRC, ">/etc/cgitrc.d/$reponame" ); # Maybe someday cgit will support cgitrc.d. @@ -218,8 +218,8 @@ repo.owner=$email close( CGITRC ); $cgitrctempfile = `/bin/mktemp`; chomp( $cgitrctempfile ); -system( "/bin/cat /etc/cgitrc.d/* > $cgitrctempfile" ); chmod ( 0644, $cgitrctempfile ); +system( "/bin/cat /etc/cgitrc.d/* > $cgitrctempfile" ); system( "/bin/mv $cgitrctempfile /etc/cgitrepos" ); # This is marginally racy, but the consequences are minor. # COMPILE |